Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove space between buttons v2 #5685

Closed
wants to merge 3 commits into from
Closed

Remove space between buttons v2 #5685

wants to merge 3 commits into from

Conversation

bradystroud
Copy link
Contributor

@bradystroud bradystroud commented Aug 5, 2021

Summary
closes #5555
This PR is the same as #5585.

I have combined the Toolbar subsections so all the buttons are together.
I have also moved the delete button so it is always on the end.

Test plan
yarn test is passing

Screen Shot 2021-07-05 at 3 42 03 pm
Figure: Open authoring view

Screen Shot 2021-07-05 at 3 43 12 pm
Figure: Normal view

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • Code is formatted via running yarn format.
  • Tests are passing via running yarn test.
  • The status checks are successful (continuous integration). Those can be seen below.

@bradystroud bradystroud requested a review from a team August 5, 2021 23:44
@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Aug 9, 2021
@erezrokah
Copy link
Contributor

@bradystroud, looks like some test are failing on CI. Are those tests passing for you locally?

@bradystroud
Copy link
Contributor Author

@bradystroud, looks like some test are failing on CI. Are those tests passing for you locally?

@erezrokah this looks like a similar issue to what you described in #5585 (comment) where the notification is covering a button. I will try implement a similar solution

@bradystroud
Copy link
Contributor Author

Closing this PR as it has been replaced by #5729
Thanks @taineriley1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move 'Set status' dropdown and 'Save' button together
2 participants