Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove svg checkmark from editor toolbar #5776

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

stefanprobst
Copy link
Contributor

@stefanprobst stefanprobst commented Sep 1, 2021

Summary

This PR removes the svg checkmark which is added to the editor toolbar successful status check, because it

Test plan

none (but snapshots have been updated)

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • Code is formatted via running yarn format.
  • Tests are passing via running yarn test.
  • The status checks are successful (continuous integration). Those can be seen below.

@stefanprobst stefanprobst requested a review from a team September 1, 2021 13:49
@erezrokah erezrokah added type: bug code to address defects in shipped code type: chore work needed to keep the product and development running smoothly and removed type: chore work needed to keep the product and development running smoothly labels Sep 1, 2021
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefanprobst, I was not able to see the checkmark as well in various browsers.

@erezrokah erezrokah merged commit 6190822 into decaporg:master Sep 10, 2021
@stefanprobst stefanprobst deleted the fix/remove-svg-checkmark branch September 10, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants