Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instructions for workaround to enable progressive image loading with gridsome #5877

Closed
wants to merge 1 commit into from

Conversation

tennox
Copy link

@tennox tennox commented Oct 8, 2021

Summary
Add instructions for a workaround to get progressive image loading.

See here:
gethypervisual/gridsome-plugin-netlify-cms#23

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • Code is formatted via running yarn format.
  • The status checks are successful (continuous integration). Those can be seen below.

@tennox tennox requested a review from a team October 8, 2021 16:39
@tennox tennox changed the title Add instructions for workaround to enable progressive image loading Add instructions for workaround to enable progressive image loading with gridsome Oct 8, 2021
@tennox tennox changed the title Add instructions for workaround to enable progressive image loading with gridsome docs: add instructions for workaround to enable progressive image loading with gridsome Oct 8, 2021
@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 8, 2021
@tennox
Copy link
Author

tennox commented Oct 8, 2021

Your lint pipeline seems broken (/bin/sh: 1: markdownlint: not found):
https://app.netlify.com/sites/netlify-cms-www/deploys/61607430ff6a1a00080b9e7d

Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tennox, can please elaborate on what the plugin does?

Based on https://germano.dev/fix-netlify-cms-paths-on-gridsome would it make sense to recommend Gridsome users to configure relative paths for their media folders?

We do it in the Gatsby guide already.

@tennox
Copy link
Author

tennox commented Oct 13, 2021

@erezrokah thank's for the tip! I'll clarify. (relevant issue)

@erezrokah
Copy link
Contributor

Hi @tennox, thanks for the PR. I'm closing this PR until tyrion/gridsome-plugin-netlify-cms-paths#12 is resolved.

Happy to discuss in a CMS issue and approve this/a new PR once we conclude on the best solution.

@erezrokah erezrokah closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants