fix: handle single file i18n when filtering #6942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 8b47d55 |
|
At first I thought I was going mad because I was sure I handled this in #6937.. Then I found the second (unpublished) commit on my local branch that looks exactly the same 😅 Thanks for this, will merge and publish as soon as checks as pipeline is done. |
demshy
approved these changes
Oct 13, 2023
martinjagodic
pushed a commit
that referenced
this pull request
Oct 16, 2023
martinjagodic
pushed a commit
that referenced
this pull request
Oct 17, 2023
martinjagodic
pushed a commit
to geotrev/netlify-cms
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#6898 introduced filtering by path for Github, but it also introduced a couple of bugs for i18n. #6937 resolved it for multi-folder project structures and it was already working for multi-file structures. However single file structures were not being filtered right, resulting in no results appearing for collections using that structure.
Test plan
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)
