Fix navigation blocker in editorial workflow #6981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decap-www canceled.
|
✅ Deploy Preview for cms-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
demshy
force-pushed
the
fix/editorial-worflow-dialog
branch
from
91f8fe4
to
c8a7e73
Compare
martinjagodic
previously approved these changes
Nov 17, 2023
…cap-cms into fix/editorial-worflow-dialog
martinjagodic
previously approved these changes
Nov 17, 2023
martinjagodic
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue discovered here: #6964
After upgrade to React 18, when saving a new entry using editorial workflow, an unnecessary navigation blocker appeared before navigating to the new entry. By choosing cancel this lead to a bunch of problems.
There was actually a problem with a dispatch not being awaited, therefore when navigation blocker display condition was checked, the state was still set as persisting. Seems like excessive re-renders in previous versions of React somehow masked the issue.
Test plan
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)