Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add EOL for files #7039

Merged
merged 2 commits into from Jan 20, 2024
Merged

fix: add EOL for files #7039

merged 2 commits into from Jan 20, 2024

Conversation

razonyang
Copy link
Contributor

Closes #1382

Summary

Test plan

Checklist

Please add a x inside each checkbox:

A picture of a cute animal (not mandatory but encouraged)

Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for decap-www canceled.

Name Link
🔨 Latest commit cfe6fae
🔍 Latest deploy log https://app.netlify.com/sites/decap-www/deploys/65abb744a9a2500008acb4c5

@martinjagodic
Copy link
Member

@razonyang the tests are failing because Cypress fixtures don't match anymore. Could you update these too, please?

@razonyang
Copy link
Contributor Author

Hi @martinjagodic, I'm willing to correct it, but I lost my direction after digging into the code, could you please share some hint?

@razonyang razonyang requested a review from a team as a code owner January 20, 2024 12:06
@demshy
Copy link
Member

demshy commented Jan 20, 2024

hi @razonyang I hope you don't mind me taking this over, but currently recording fixtures does not really work because the whole cypress part is awaiting a large overhaul. The process that I currently use is quite manual and specific, so I will describe it here for future reference (also for me and @martinjagodic). I wanted to write these instructions but after I was finished the tests were working already, so it didn't make sense to me to make you do them again :)

a) run yarn test:e2e and wait for it to finish, to see which tests failed
b) run yarn test:e2e:dev and manually run the failed test(s) with the console open
c) notice the yellow warning about 404 request right before the test failing - it contains a content hash that you'll want to copy
d) find the correct file for the test in cypress/fixtures and find the request - in this case you could search by the hash start, since only the ending of the content is different
e) once you found the request, find and replace content hash with the one you copied from step c)
repeat b) until the test passes.. by using find and replace you possibly fixed multiple tests so if you suspect this, do a) again

@razonyang
Copy link
Contributor Author

razonyang commented Jan 20, 2024

@demshy Of course I don't mind, I'm completely newbie on this project, I have no idea on how to fix the tests, now I learned it from your code.

@demshy
Copy link
Member

demshy commented Jan 20, 2024

No worries, it's quite overwhelming for most of us.
As I said the goal is to make this more automatic and documented, but one step at a time I guess :)

Anyhow, this seemed to do the trick

@demshy demshy merged commit 6a45d3b into decaporg:master Jan 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON files are saved with no newline at the end of file
3 participants