Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix types of component interface #7097

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

sscaff1
Copy link
Contributor

@sscaff1 sscaff1 commented Feb 12, 2024

Summary

The interface EditorComponentOptions does not match the documentation or usage. toPreview should be able to return a JSX.Element. Fields should be optional (for example, you create a component like a horizontal rule that would have no fields).

Test plan

This is just changing types.

Checklist

Please add a x inside each checkbox:

A picture of a cute animal (not mandatory but encouraged)

@sscaff1 sscaff1 requested a review from a team as a code owner February 12, 2024 17:25
Copy link
Member

@martinjagodic martinjagodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinjagodic martinjagodic enabled auto-merge (squash) March 5, 2024 11:25
@martinjagodic martinjagodic merged commit 77bec1f into decaporg:master Mar 7, 2024
9 checks passed
@sscaff1 sscaff1 deleted the fix-types branch March 7, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants