Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle single values in multi select relation widget #7164

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

demshy
Copy link
Member

@demshy demshy commented Apr 2, 2024

Summary
This should patch up a bug that was introduced here: #7161
There is an edge case that we use for our client where relation widget is collapsed within an list and if the widget wasn't displayed right away it would populate the value as if it was a single value field and after saving the format would be corrupted.

Test plan
Add the following field to the list of authors in config.yml

- { name: 'posts', widget: relation, collection: posts, multiple: true, search_fields: [ "title" ], display_fields: [ "title" ], value_field: "{{slug}}", filters: [ {field: "draft", values: [false]} ] }

In settings > authors add a single related post, publish (so far so good), close and open authors again. The value would be blank before this patch but is correctly populated now.

Checklist

Please add a x inside each checkbox:

A picture of a cute animal (not mandatory but encouraged)

@demshy demshy requested a review from a team as a code owner April 2, 2024 09:42
@demshy demshy merged commit 248f36f into decaporg:main Apr 2, 2024
11 checks passed
@demshy demshy deleted the fix/relation-widget branch April 2, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants