Disable login button while login is in progress. #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech4him1
force-pushed
the
disable-login-button-while-working
branch
3 times, most recently
from
b8a5011
to
2e6a5ef
Compare
tech4him1
force-pushed
the
disable-login-button-while-working
branch
from
2e6a5ef
to
7225a12
Compare
tech4him1
changed the title
tech4him1
changed the title
tech4him1
changed the title
|
Just a note: this has not been implemented for Identity, as that flow is kind-of separate and uses a modal anyway. |
|
@tech4him1 understood, thanks. |
erquhart
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Since the authentication can occur in another window, or it can occur behind the scenes when restoring locally saved credentials, the login button should be disabled while the login is running. This makes it clearer for the user.
- Test plan
Login works normally. The login button is disabled while logging in (or restoring login).
- Description for the changelog
Disable login button while login is in progress.
- A picture of a cute animal (not mandatory but encouraged)