Cleanup file formatters. #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech4him1
force-pushed
the
cleanup-formats
branch
2 times, most recently
from
d96a745
to
7cec472
Compare
We want to use our file parsers for frontmatter, instead of the builtin ones, as they process some formats (images, dates) properly.
tech4him1
force-pushed
the
cleanup-formats
branch
from
7cec472
to
f0fe09c
Compare
erquhart
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
This PR aims to clean up the
/src/formatscode.@erquhart @Benaiah What do you think on "Use same parsers for files and frontmatter."? I think this will be better to retain consistency in the future -- so things like AssetProxy and Moment.js can be interpreted correctly in frontmatter as well (instead of just in the data-file formatters).
FOR REVIEW: The easiest way to review this PR will probably be to review each commit separately, the history should be clean.
- Test plan
Tested manually with example site to ensure files are still being saved with correct format/extension.
- Description for the changelog
Cleanup file formatters.
- A picture of a cute animal (not mandatory but encouraged)