Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add generic error boundary, apply to preview iframe #779

Merged
merged 1 commit into from
Nov 11, 2017
Merged

add generic error boundary, apply to preview iframe #779

merged 1 commit into from
Nov 11, 2017

Conversation

erquhart
Copy link
Contributor

@erquhart erquhart commented Nov 7, 2017

Related to #778, doesn't quite close.

@erquhart erquhart mentioned this pull request Nov 7, 2017
Closed
tech4him1
tech4him1 approved these changes Nov 9, 2017
View reviewed changes
Copy link
Contributor

@tech4him1 tech4him1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the content in the iFrame could actually break the CMS anyway -- for example, add <script>{throw "this is inside"}</script> to the initialContent or the PreviewContent -- it doesn't actually break React at all, as far as I can tell.

@erquhart erquhart merged commit b3af4e8 into master Nov 11, 2017
@erquhart erquhart deleted the error-boundary branch November 11, 2017 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benaiah Benaiah Benaiah approved these changes

@tech4him1 tech4him1 tech4him1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erquhart @Benaiah @tech4him1