Infer format from extension for new entries. #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech4him1
force-pushed
the
776-infer-format-ext
branch
from
24889df
to
d6f7d6b
Compare
tech4him1
changed the title
|
This should be blocked until 0.8.0. |
If a collection has no format specified, we try to infer the format from the file extension when reading. This commit also allows us to infer the format from the `extension` set in the config, so that we can still create the correct format when making a new file.
erquhart
force-pushed
the
776-infer-format-ext
branch
from
d6f7d6b
to
799d566
Compare
|
Deploy preview ready! Built with commit 799d566 |
erquhart
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
If a collection has no format specified, we try to infer the format from
the file extension when reading. This commit also allows us to infer the
format from the
extensionset in the config, so that we can stillcreate the correct format when making a new file.
Fixes #776.
(Re)based on #795.
- Test plan
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)