Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update integrations check to account for null default state #814

Merged
merged 1 commit into from
Nov 12, 2017
Merged

update integrations check to account for null default state #814

merged 1 commit into from
Nov 12, 2017

Conversation

erquhart
Copy link
Contributor

#804 checked the integrations state object with the assumption that a truthy default state (like Map()) was provided - this fix checks for existence first. Not switching default to Map() to ensure against unexpected breaks.

Jinksi
Jinksi approved these changes Nov 12, 2017
View reviewed changes
Copy link
Contributor

@Jinksi Jinksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 🎉

@erquhart erquhart merged commit 7c54fbd into master Nov 12, 2017
@erquhart erquhart deleted the fix-entry-save branch November 12, 2017 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jinksi Jinksi Jinksi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erquhart @Jinksi