Prompt before exiting tab with unsaved changes #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech4him1
reviewed
Nov 13, 2017
src/containers/EntryPage.js
Outdated
| } | ||
|
|
||
| const unblock = history.block(this.blocker); | ||
| window.onbeforeunload = window.onbeforeunload || this.blocker; |
There was a problem hiding this comment.
Just wonder if using addEventListener and removeEventListener would be better here.
There was a problem hiding this comment.
window.addEventListener("beforeunload", this.blocker) and window.removeEventListener("beforeunload", this.blocker)
Benaiah
force-pushed
the
prompt-before-closing-entry-page
branch
from
03ded66
to
ba78589
Compare
Benaiah
force-pushed
the
prompt-before-closing-entry-page
branch
from
ba78589
to
8b56849
Compare
erquhart
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Prompts before closing the entry page if there are unsaved changes present. Closes #286.
- Test plan
Tested manually.
- Description for the changelog
Prompt before exiting tab with unsaved changes