Throw on unsupported format. #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech4him1
changed the title
tech4him1
force-pushed
the
throw-unsupported-format
branch
from
07e9b5d
to
2ecc535
Compare
tech4him1
changed the title
|
Looks like this is broken -- please don't merge. |
|
We won't merge as long as it's WIP, no worries. |
tech4him1
force-pushed
the
throw-unsupported-format
branch
from
9301ca5
to
d21ae0e
Compare
tech4him1
changed the title
|
OK, this should be ready for review again. The |
|
@erquhart Please re-review before merge -- a few new commits were added. |
Also clarify collection validation messages.
The `frontmatter` format is the correct one to use here.
erquhart
force-pushed
the
throw-unsupported-format
branch
from
dc59840
to
dede8e0
Compare
|
Deploy preview ready! Built with commit dede8e0 |
erquhart
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Closes #797.
If a format is specified that is unsupported, throw instead of just saving as markdown/frontmatter.
(Re)based on #795.
- Test plan
No regressions seen on
/examplesite.Threw if unsupported format set.
- Description for the changelog
Throw on unsupported format.
- A picture of a cute animal (not mandatory but encouraged)