Enable WebPack scope hoisting. #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only enabled for the production build, as it breaks Hot Module Reloading.
tech4him1
force-pushed
the
scope-hoisting
branch
from
f4cdcf8
to
d06ffa3
Compare
tech4him1
changed the title
erquhart
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
WebPack 3 now has scope hoisting, which optimizes bundle speed at runtime. It also decreases bundle size, though the change is small. This is basically the main benefit that Rollup was designed with, except failsafe (more info here: https://medium.com/webpack/webpack-freelancing-log-book-week-5-7-4764be3266f5).
For now, this is only enabled for the production build, as it would break Hot Module Reloading.
- Test plan
CMS deploy preview seems to work fine for me (but that probably isn't much good as a test 😁).
- Description for the changelog
Enable WebPack scope hoisting.
- A picture of a cute animal (not mandatory but encouraged)
