Use cached images for new uploads #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 868e57b |
|
Deploy preview ready! Built with commit 868e57b |
tech4him1
force-pushed
the
fix-new-uploads
branch
from
8054946
to
c565750
Compare
tech4him1
changed the title
erquhart
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Before we had the media library, we used uploaded image data directly when it was first uploaded, since it was likely not deployed yet. With the media library, we should be able to do this as well.
@erquhart Is this the correct fix, or do we need more in-depth changes?
- Test plan
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)