#895 Adding an image to an empty rich text editor doesn't trigger the Image widget #926
Conversation
|
Deploy preview ready! Built with commit 745c4e2 |
|
Deploy preview ready! Built with commit 745c4e2 |
| @@ -7,9 +7,9 @@ const image = { | |||
| image: match[2], | |||
| alt: match[1], | |||
| }, | |||
| toBlock: data => ``, | |||
| toBlock: data => ``, | |||
| toPreview: (data, getAsset) => <img src={getAsset(data.image || '')} alt={data.alt || ''} />, | |||
There was a problem hiding this comment.
@erquhart I noticed that you modified this line as well in your 1.0 changes -- I had it as src={getAsset(data.image) || ''}. Is that something that needs reverted/fixed as well?
There was a problem hiding this comment.
@tech4him1 good catch, yes, that was unintentional.
| @@ -7,9 +7,9 @@ const image = { | |||
| image: match[2], | |||
| alt: match[1], | |||
| }, | |||
| toBlock: data => ``, | |||
There was a problem hiding this comment.
@Dammmien I'm just wondering why we want it to be undefined instead of an empty string, since that was just implemented recently. I'm not saying it's wrong, I'd just like a little background on why you can to change it.
There was a problem hiding this comment.
I think his reasoning lies in comparison to the youtube component:
Input will be filled with undefined label ( the youtube widget has this behavior ).
But yeah I agree, should be empty string. Have a commit going that I'll be pushing soon, should be good to merge after that.
erquhart
force-pushed
the
fix/add_image_empty_rich_text_editor
branch
from
df63859
to
745c4e2
Compare
There was a problem hiding this comment.
@Dammmien thanks for this! Quick review of my changes:
- the dot operator captures everything except line breaks, but
\S\scaptures everything plus line breaks. Since line breaks aren't needed in alt text or the url, I've switched to the dot operator. - Implemented the fix pointed out by @tech4him1, where the
ORoperator was meant to be outside of thegetAssetcall args.
Fixes #895 : Adding an image to an empty rich text editor doesn't trigger the Image widget.
- Summary
Input will be filled with
undefinedlabel ( the youtube widget has this behavior ).- Test plan
Add an image to an empty rich text editor
- Description for the changelog
Input will be filled with
undefinedlabel ( the youtube widget has this behavior ).