Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect overflow handling in predict_trajectory() when relift=False #118

Merged
merged 1 commit into from Dec 17, 2022
Merged

Incorrect overflow handling in predict_trajectory() when relift=False #118

merged 1 commit into from Dec 17, 2022

Conversation

sdahdah
Copy link
Member

@sdahdah sdahdah commented Dec 16, 2022 •
edited

Resolves #117

Proposed Changes

  • Remove reference to X_ikm1

Checklist

  • Write unit tests
  • Add new estimators to existing scikit-learn compatibility tests
  • Write examples in docstrings
  • Update Sphinx documentation

@sdahdah sdahdah added the bug Something isn't working label Dec 16, 2022
@sdahdah sdahdah added this to the v1.1.1 milestone Dec 16, 2022
@sdahdah sdahdah self-assigned this Dec 16, 2022
@sdahdah sdahdah linked an issue Dec 16, 2022 that may be closed by this pull request
Incorrect overflow handling in predict_trajectory() when relift=False #117
Closed
@sdahdah sdahdah merged commit 7ee592e into main Dec 17, 2022
@sdahdah sdahdah deleted the bugfix/117-incorrect-overflow-handling-in-predict_trajectory-when-relift=false branch December 17, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sdahdah sdahdah

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

Incorrect overflow handling in predict_trajectory() when relift=False
1 participant
@sdahdah