Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine release procedure #121

Closed
sdahdah opened this issue Dec 17, 2022 · 1 comment · Fixed by #124
Closed

Refine release procedure #121

sdahdah opened this issue Dec 17, 2022 · 1 comment · Fixed by #124
Assignees
@sdahdah
Labels
documentation Improvements or additions to documentation
Milestone
v1.2.0

Comments

@sdahdah
Copy link
Member

sdahdah commented Dec 17, 2022

I forgot to bump the version in the source code from v1.1.0 to v1.1.1. PyPi rejected the release, but Zenodo accepted it. When fixing this, PyPi accepted the new package, but Zenodo rejected it. So I had to draft v1.1.2 to make everything consistent again.

I need to look into an automated check to prevent this from happening. If not that, then at least a written checklist to follow.
@sdahdah sdahdah added the enhancement New feature or request label Dec 17, 2022
@sdahdah sdahdah added this to the v1.2.0 milestone Dec 17, 2022
@sdahdah sdahdah self-assigned this Dec 17, 2022
@sdahdah sdahdah added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Dec 17, 2022
@sdahdah
Copy link
Member Author

sdahdah commented Dec 20, 2022

For now I've at least added an item in the pull request checklist.

@sdahdah sdahdah mentioned this issue Dec 20, 2022
Merged
5 tasks
@sdahdah sdahdah linked a pull request Dec 20, 2022 that will close this issue
Refine release procedure #124
Merged
5 tasks
@sdahdah sdahdah modified the milestones: v1.2.0, v1.1.4 Dec 20, 2022
@sdahdah sdahdah modified the milestones: v1.1.4, v1.2.0 Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdahdah sdahdah

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Refine release procedure decargroup/pykoop
1 participant
@sdahdah