Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine release procedure #124

Merged
merged 5 commits into from Jan 6, 2023
Merged

Refine release procedure #124

merged 5 commits into from Jan 6, 2023

Conversation

sdahdah
Copy link
Member

@sdahdah sdahdah commented Dec 20, 2022 •
edited

Resolves #121

Proposed Changes

  • Remove date from CITATION.cff
  • Add GitHub action to check version consistency

Checklist

  • Write unit tests
  • Add new estimators to existing scikit-learn compatibility tests
  • Write examples in docstrings
  • Update Sphinx documentation
  • Bump version number and date in setup.py, CITATION.cff, and
    README.rst

@sdahdah sdahdah added the documentation Improvements or additions to documentation label Dec 20, 2022
@sdahdah sdahdah added this to the v1.2.0 milestone Dec 20, 2022
@sdahdah sdahdah self-assigned this Dec 20, 2022
@sdahdah sdahdah linked an issue Dec 20, 2022 that may be closed by this pull request
Refine release procedure #121
Closed
@sdahdah
Copy link
Member Author

sdahdah commented Dec 20, 2022 •
edited

Issue: get-version-action returns pushed refs that are not release tags.

EDIT: Fixed by checking PyPi version.

@sdahdah sdahdah modified the milestones: v1.2.0, v1.1.4 Dec 20, 2022
@sdahdah sdahdah merged commit 6939d2a into main Jan 6, 2023
@sdahdah sdahdah deleted the feature/121-refine-release-procedure branch January 6, 2023 16:06
@sdahdah sdahdah modified the milestones: v1.1.4, v1.2.0 Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sdahdah sdahdah

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Refine release procedure
1 participant
@sdahdah