Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of a KoopmanRegressor object from a Koopman matrix #125

Closed
sdahdah opened this issue Jan 4, 2023 · 0 comments · Fixed by #129
Closed

Allow creation of a KoopmanRegressor object from a Koopman matrix #125

sdahdah opened this issue Jan 4, 2023 · 0 comments · Fixed by #129
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sdahdah
Copy link
Member

sdahdah commented Jan 4, 2023

Desired Behavior

Given a Koopman matrix U, create a KoopmanRegressor object that functions as if it was fit with pykoop.

Proposed Solution

Along these lines:

class DataRegressor(KoopmanRegressor):

    def __init__(self, U):
        self.U = U
        
    def fit(X, y):
        self.n_features_in_ = ...
        self.coef_ = U.copy()
@sdahdah sdahdah added the enhancement New feature or request label Jan 4, 2023
@sdahdah sdahdah added this to the v1.2.0 milestone Jan 4, 2023
@sdahdah sdahdah self-assigned this Jan 4, 2023
@sdahdah sdahdah changed the title Add dummy fit regressor from data Allow creation of a KoopmanRegressor object from a Koopman matrix Jan 6, 2023
@sdahdah sdahdah linked a pull request Jan 6, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant