Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

score_trajectory() sometimes returns inf instead of error score #128

Merged
merged 3 commits into from Jan 6, 2023
Merged

score_trajectory() sometimes returns inf instead of error score #128

merged 3 commits into from Jan 6, 2023

Conversation

sdahdah
Copy link
Member

@sdahdah sdahdah commented Jan 6, 2023 •
edited

Resolves #126

Proposed Changes

  • Add check to output of score_trajectory() in case the score becomes NaN or inf during its calculation.

Checklist

  • Write unit tests
  • Add new estimators to existing scikit-learn compatibility tests
  • Write examples in docstrings
  • Update Sphinx documentation
  • Bump version number and date in setup.py, CITATION.cff, and
    README.rst

@sdahdah sdahdah added the bug Something isn't working label Jan 6, 2023
@sdahdah sdahdah added this to the v1.1.4 milestone Jan 6, 2023
@sdahdah sdahdah self-assigned this Jan 6, 2023
@sdahdah sdahdah merged commit a9f1f51 into main Jan 6, 2023
@sdahdah sdahdah deleted the feature/126-score_trajectory-sometimes-returns-inf-instead-of-error_score branch January 6, 2023 16:57
@sdahdah sdahdah modified the milestones: v1.1.4, v1.2.0 Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sdahdah sdahdah

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

score_trajectory() sometimes returns -inf instead of error_score
1 participant
@sdahdah