Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit tests #40

Closed
sdahdah opened this issue Oct 19, 2021 · 2 comments · Fixed by #58
Closed

Improve unit tests #40

sdahdah opened this issue Oct 19, 2021 · 2 comments · Fixed by #58

Comments

@sdahdah
Copy link
Member

sdahdah commented Oct 19, 2021

Some unit tests are slow and require Mosek, so they can't be run server-side. Only a subset of the tests are currently run. Unit tests need to be reorganized so that the most possible tests can be run at each merge.

@sdahdah
Copy link
Member Author

sdahdah commented Oct 21, 2021

Mosek OptServer can be used to run slow tests:

 _default_solver_params: Dict[str, Any] = {
    'mosek_server': 'http://solve.mosek.com:30080',
}

May need to add a PyTest marker for tests that require an internet connection then...

@sdahdah
Copy link
Member Author

sdahdah commented Dec 16, 2021

Also need to remove raw floating point values from doctests, as they can vary by platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant