Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip rescaling of original states #63

Closed
sdahdah opened this issue Jun 1, 2022 · 1 comment
Closed

Add option to skip rescaling of original states #63

sdahdah opened this issue Jun 1, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on
Milestone

Comments

@sdahdah
Copy link
Member

sdahdah commented Jun 1, 2022

Scale only lifted states without rescaling original states? Maybe the PolynomialLiftingFn should handle its own scaling.

Either way, it's becoming more clear that normalizing and standardizing should be done outside of the KoopmanPipeline, or within each lifting function as needed. But having a "normalizing" lifting function is a bit awkward since we want to keep the original state inside the lifted state unmodified.

@sdahdah sdahdah added the enhancement New feature or request label Sep 2, 2022
@sdahdah sdahdah self-assigned this Sep 6, 2022
@sdahdah sdahdah added this to the v1.1.0 milestone Sep 7, 2022
@sdahdah sdahdah added the wontfix This will not be worked on label Sep 22, 2022
@sdahdah
Copy link
Member Author

sdahdah commented Sep 22, 2022

I think, for now, normalizing/standardizing data should be done outside of the Koopman pipeline. The second-best option is for PolynomialLiftingFn to rescale its lifted states without rescaling the original state. But this could get confusing and messy. It could also lead to weird weighting issues if the lifted states are way smaller than the original states.

@sdahdah sdahdah closed this as completed Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant