Skip to content

Commit

Permalink
Modifier "public" is redundant for interface methods
Browse files Browse the repository at this point in the history
  • Loading branch information
decebals committed May 21, 2016
1 parent 8cb08e1 commit b022037
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 17 deletions.
12 changes: 6 additions & 6 deletions dada-core/src/main/java/ro/fortsoft/dada/core/GenericDao.java
Original file line number Diff line number Diff line change
Expand Up @@ -31,36 +31,36 @@ public interface GenericDao<T extends Identifiable<ID>, ID extends Serializable>
* @param id
* @return
*/
public T findById(ID id);
T findById(ID id);

public List<T> findByExample(T example);
List<T> findByExample(T example);

/**
* Returns all the {@link Identifiable} entities.
*
* @return
*/
public List<T> findAll();
List<T> findAll();

/**
* Stores the {@link Identifiable} entity.
*
* @param entity
* @return
*/
public T save(T entity);
T save(T entity);

/**
* Removes the {@link Identifiable} entity.
*
* @param id
*/
public boolean deleteById(ID id);
boolean deleteById(ID id);

/**
* Returns the total number of entities.
* @return
*/
public long count();
long count();

}
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ public interface Identifiable<T extends Serializable> {
*
* @return
*/
public T getId();
T getId();

/**
* Sets the identifier.
*
* @param id
*/
public void setId(T id);
void setId(T id);

}
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,16 @@
*/
public interface GenericService<T extends Identifiable<ID>, ID extends Serializable> {

public T findById(ID id);
T findById(ID id);

public List<T> findByExample(T example);
List<T> findByExample(T example);

public List<T> findAll();
List<T> findAll();

public boolean deleteById(ID id);
boolean deleteById(ID id);

public T save(T entity);
T save(T entity);

public long count();
long count();

}
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
*/
public interface CompanyDao extends EntityDao<Company> {

public Company findByFiscalCode(String fiscalCode);
Company findByFiscalCode(String fiscalCode);

}
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
*/
public interface CompanyService extends EntityService<Company> {

public Company findByFiscalCode(String fiscalCode);
Company findByFiscalCode(String fiscalCode);

}
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
*/
public interface IciqlDbFactory {

public Db getDb();
Db getDb();

}

0 comments on commit b022037

Please sign in to comment.