feat: MainPage container #360

braianj · 2024-05-17T18:02:28Z

src/components/ConfirmPage/ConfirmPage.tsx

meelrossi · 2024-05-17T19:46:45Z

src/components/ConfirmPage/ConfirmPage.types.tsx

+
+export type MapStateProps = Pick<Props, 'isLoading'>
+export type MapDispatchProps = Pick<Props, 'onValidateSubscriptionEmailRequest'>
+export type MapDispatch = Dispatch


maybe you can use Dispatch directly or add action types here

src/components/MainPage/MainPage.container.ts

meelrossi · 2024-05-17T19:51:08Z

src/components/MainPage/MainPage.styled.ts

+  position: 'relative'
+})
+
+export const Box = styled(BoxMui)({


i see that this is repeated in the confirmationPage is there a way to reuse it

when the UI2 is ready, we will no longer need the customization

meelrossi · 2024-05-17T19:52:44Z

src/components/MainPage/MainPage.tsx

+  const { children, value, index } = props
+
+  return (
+    <TabPanelContainer role="tabpanel" hidden={value !== index} id={`vertical-tabpanel-${index}`} aria-labelledby={`vertical-tab-${index}`}>


is this in the ui component vertical-tab-${index} ?

meelrossi · 2024-05-17T19:54:57Z

src/components/Notifications/Notifications.tsx

@@ -14,7 +15,7 @@ export const NOTIFICATION_DESCRIPTION_TEST_ID = 'notification-description-test-i

 export default function Notifications(props: Props) {
  const { onGetSubscription } = props
-
+  const isTabletOrBelow = useMediaQuery('(max-width:991px)')


maybe in the future we can add this in decentraland-ui so we don't have to repeat the max-width everywhere

yes, we should

src/components/Routes/Routes.tsx

src/components/ConfirmPage/ConfirmPage.container.ts

src/components/SignInPage/SignInPage.tsx

src/components/ConfirmPage/ConfirmPage.types.tsx

src/components/MainPage/MainPage.types.tsx

cyaiox · 2024-05-17T21:38:36Z

src/components/MainPage/MainPage.types.tsx

+
+export type MapStateProps = Pick<Props, 'isLoading'>
+export type MapDispatchProps = {}
+export type MapDispatch = Dispatch


Suggested change

export type MapDispatch = Dispatch

export type MapDispatch = Dispatch<GetSubscriptionsRequestAction>

feat: MainPage container

673708c

braianj self-assigned this May 17, 2024

vercel bot deployed to Preview May 17, 2024 18:04 View deployment

braianj added 2 commits May 17, 2024 15:06

feat: remove description from MainPage

f1e26b0

feat: remove unneeded variables

342a0de

vercel bot deployed to Preview May 17, 2024 18:18 View deployment

WIP

ec64548

vercel bot had a problem deploying to Preview May 17, 2024 19:18 Failure

meelrossi reviewed May 17, 2024

View reviewed changes