Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR-133: add websocket and fetch details #256

Merged
merged 2 commits into from Sep 26, 2023

Conversation

leanmendoza
Copy link
Contributor

@leanmendoza leanmendoza commented Sep 18, 2023

@leanmendoza leanmendoza requested a review from a team as a code owner September 18, 2023 17:45
@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 81f5bed
Status: ✅  Deploy successful!
Preview URL: https://028c5793.adr-cvq.pages.dev
Branch Preview URL: https://feat-add-fetch-and-ws-detail.adr-cvq.pages.dev

View logs

@leanmendoza leanmendoza requested review from gonpombo8 and removed request for menduz September 18, 2023 17:45
Copy link
Member

@pravusjif pravusjif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marianogoldman marianogoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typo and free to merge.

content/ADR-133-scene-runtime.md Outdated Show resolved Hide resolved
Co-authored-by: Mariano Goldman <marianogoldman@users.noreply.github.com>
Signed-off-by: Lean Mendoza <leandro@decentraland.org>
@leanmendoza leanmendoza enabled auto-merge (squash) September 26, 2023 14:45
@leanmendoza leanmendoza merged commit cab5d2f into main Sep 26, 2023
2 checks passed
@leanmendoza leanmendoza deleted the feat/add-fetch-and-ws-details branch September 26, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants