New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Query signatures server using milliseconds instead of seconds #100

Merged

LautaroPetaccio merged 1 commit into master from fix/update-rentals-with-milliseconds

Oct 17, 2023

Contributor

LautaroPetaccio commented Oct 17, 2023

As the JSDoc says, the server admits a date in milliseconds and we're querying the server using seconds.

  /** Gets the updated rental listings that were updated after the given date.
   * @param updatedAfter A UTC timestamp in milliseconds of the rental listings update time.
   * @throws An error if the request fails.
   */


          fix: Query signatures server using milliseconds instead of seconds

283e2fb

juanmahidalgo approved these changes

View reviewed changes

Contributor

juanmahidalgo left a comment

LGTM!

LautaroPetaccio merged commit 18ded22 into master

1 check passed

LautaroPetaccio deleted the fix/update-rentals-with-milliseconds branch

October 17, 2023 15:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment