fix: Item update (#728)

* fix: Item update * fix: Remove unecessary logic
decentraland · Jan 17, 2024 · 58e4c6a · 58e4c6a
1 parent df61133
commit 58e4c6a
Show file tree

Hide file tree

Showing 5 changed files with 503 additions and 469 deletions.
diff --git a/src/Collection/Collection.service.ts b/src/Collection/Collection.service.ts
@@ -535,11 +535,14 @@ export class CollectionService {
   public async isDCLManager(id: string, ethAddress: string): Promise<boolean> {
     const collection = await this.getCollection(id)
 
-    if (collection) {
-      return collection.managers.some((manager) => manager === ethAddress)
-    }
+    return collection && this.isDCLManagerOfCollection(collection, ethAddress)
+  }
 
-    return false
+  public isDCLManagerOfCollection(
+    collection: CollectionAttributes,
+    ethAddress: string
+  ): boolean {
+    return collection.managers.some((manager) => manager === ethAddress)
   }
 
   public async isOwnedOrManagedBy(

diff --git a/src/Item/Item.errors.ts b/src/Item/Item.errors.ts
@@ -84,7 +84,7 @@ export class UnauthorizedToChangeToCollectionError extends Error {
     public eth_address: string,
     public collection_id: string
   ) {
-    super("The new collection for the item isn't owned by the same owner.")
+    super("You're not authorized to to change this collection.")
   }
 }