fix: Fix query for the /item endpoint (#529)

decentraland · May 24, 2022 · 5e5d05b · 5e5d05b
1 parent 584f541
commit 5e5d05b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/Item/Item.router.spec.ts b/src/Item/Item.router.spec.ts
@@ -173,6 +173,10 @@ describe('Item router', () => {
           .set(createAuthHeaders('get', url))
           .expect(200)
           .then((response: any) => {
+            expect(collectionAPI.fetchCollectionWithItem).toHaveBeenCalledWith(
+              dbCollectionMock.contract_address,
+              `${dbCollectionMock.contract_address}-${dbItem.blockchain_item_id}`
+            )
             expect(response.body).toEqual({
               data: {
                 ...resultingItem,

diff --git a/src/Item/Item.service.ts b/src/Item/Item.service.ts
@@ -305,7 +305,7 @@ export class ItemService {
         item: remoteItem,
       } = await collectionAPI.fetchCollectionWithItem(
         dbCollection.contract_address!,
-        dbItem.blockchain_item_id
+        `${dbCollection.contract_address}-${dbItem.blockchain_item_id}`
       )
 
       if (remoteCollection) {

diff --git a/src/ethereum/api/collection.ts b/src/ethereum/api/collection.ts
@@ -178,7 +178,9 @@ export class CollectionAPI extends BaseGraphAPI {
     return collections.length > 0 ? collections[0] : null
   }
 
-  fetchCollections = async (filters: CollectionQueryFilters): Promise<CollectionFragment[]> => {
+  fetchCollections = async (
+    filters: CollectionQueryFilters
+  ): Promise<CollectionFragment[]> => {
     return this.paginate(['collections'], {
       query: getCollectionsQuery(filters),
     })
@@ -201,18 +203,15 @@ export class CollectionAPI extends BaseGraphAPI {
     )
   }
 
-  fetchCollectionWithItem = async (
-    contractAddress: string,
-    tokenId: string
-  ) => {
+  fetchCollectionWithItem = async (contractAddress: string, itemId: string) => {
     const {
       data: { collections = [], items = [] },
     } = await this.query<{
       collections: CollectionFragment[]
       items: ItemFragment[]
     }>({
       query: getCollectionWithItemByIdsQuery(),
-      variables: { id: contractAddress.toLowerCase(), tokenId },
+      variables: { id: contractAddress.toLowerCase(), itemId },
     })
 
     return {