chore: rename method and update test

decentraland · Apr 12, 2022 · a163a11 · a163a11
1 parent 5e6084e
commit a163a11
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/src/Item/Item.model.ts b/src/Item/Item.model.ts
@@ -70,7 +70,7 @@ export class Item extends Model<ItemAttributes> {
 
   // PAGINATED QUERIES
 
-  static findAllItemsByAddress(
+  static findItemsByAddress(
     address: string,
     thirdPartyIds: string[],
     parmas: {

diff --git a/src/Item/Item.router.spec.ts b/src/Item/Item.router.spec.ts
@@ -298,7 +298,7 @@ describe('Item router', () => {
     let allAddressItems: ItemAttributes[]
     beforeEach(() => {
       allAddressItems = [dbItem, dbItemNotPublished, dbTPItem]
-      ;(Item.findAllItemsByAddress as jest.Mock).mockResolvedValueOnce(
+      ;(Item.findItemsByAddress as jest.Mock).mockResolvedValueOnce(
         allAddressItems.map((item) => ({
           ...item,
           total_count: allAddressItems.length,
@@ -345,7 +345,7 @@ describe('Item router', () => {
               ],
               ok: true,
             })
-            expect(Item.findAllItemsByAddress).toHaveBeenCalledWith(
+            expect(Item.findItemsByAddress).toHaveBeenCalledWith(
               wallet.address,
               [thirdPartyFragmentMock.id],
               {
@@ -358,14 +358,15 @@ describe('Item router', () => {
       })
     })
 
-    describe('and pagination params are passed', () => {
+    describe('and pagination & collectionId params are passed', () => {
       let baseUrl: string
       let page: number
       let limit: number
+      let collectionId: string
       beforeEach(() => {
-        ;(page = 1), (limit = 1)
+        ;(page = 1), (limit = 1), (collectionId = 'null')
         baseUrl = `/${wallet.address}/items`
-        url = `${baseUrl}?limit=${limit}&page=${page}`
+        url = `${baseUrl}?limit=${limit}&page=${page}&collectionId=${collectionId}`
       })
       it('should call the find method with the pagination params', () => {
         return server
@@ -393,13 +394,13 @@ describe('Item router', () => {
               },
               ok: true,
             })
-            expect(Item.findAllItemsByAddress).toHaveBeenCalledWith(
+            expect(Item.findItemsByAddress).toHaveBeenCalledWith(
               wallet.address,
               [thirdPartyFragmentMock.id],
               {
                 limit,
                 offset: page - 1, // it's the offset
-                collectionId: undefined,
+                collectionId,
               }
             )
           })

diff --git a/src/Item/Item.service.ts b/src/Item/Item.service.ts
@@ -178,7 +178,7 @@ export class ItemService {
 
     const thirdPartyIds = thirdParties.map((thirdParty) => thirdParty.id)
 
-    return Item.findAllItemsByAddress(address, thirdPartyIds, params)
+    return Item.findItemsByAddress(address, thirdPartyIds, params)
   }
 
   /**