fix: DCL item upsert url (#381)

decentraland · Jan 12, 2022 · c5a6c1b · c5a6c1b
1 parent 2fdc7b1
commit c5a6c1b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Item/Item.router.spec.ts b/src/Item/Item.router.spec.ts
@@ -817,7 +817,7 @@ describe('Item router', () => {
 
     describe('and the item is a DCL item', () => {
       beforeEach(() => {
-        itemToUpsert = { ...itemToUpsert, urn: null }
+        itemToUpsert = { ...itemToUpsert, urn }
         collectionMock = {
           ...collectionMock,
           urn_suffix: null,

diff --git a/src/Item/utils.ts b/src/Item/utils.ts
@@ -19,9 +19,10 @@ export function getDecentralandItemURN(
 export function toDBItem(item: FullItem): ItemAttributes {
   const attributes = {
     ...item,
-    urn_suffix: item.urn
-      ? decodeThirdPartyItemURN(item.urn).item_urn_suffix
-      : null,
+    urn_suffix:
+      item.urn && isTPItemURN(item.urn)
+        ? decodeThirdPartyItemURN(item.urn).item_urn_suffix
+        : null,
   }
   return utils.omit(attributes, [
     'urn',
@@ -66,6 +67,10 @@ export function decodeThirdPartyItemURN(
   }
 }
 
+export function isTPItemURN(itemURN: string): boolean {
+  return tpwItemURNRegex.test(itemURN)
+}
+
 // TODO: @TPW: implement this
 export function getMergedItem(_id: string): Promise<FullItem> {
   return {} as any