-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add content hash #303
Merged
cazala
merged 5 commits into
feat/improve-wearables-approval-flow
from
feat/add-content-hash
Oct 8, 2021
Merged
feat: add content hash #303
cazala
merged 5 commits into
feat/improve-wearables-approval-flow
from
feat/add-content-hash
Oct 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entraland/builder-server into feat/add-content-hash
Pull Request Test Coverage Report for Build 1320679633
💛 - Coveralls |
fzavalia
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
The routes seem better like this
cazala
added a commit
that referenced
this pull request
Oct 8, 2021
* feat: Accept changes for items in a published collection (#270) * feat: Items of published collections can be upserted * fix: isCollectionOwnerDifferent * fix: isItemCollectionBeingChanged * fix: isItemCollectionBeingChanged * refactor: Use less '?.' and ternary operators * feat: Add jest + simple test * Update jest.config.js * chore: Add test:watch npm script * chore: Add more tests * chore: More tests * chore: Reset mocks * chore: Collection with different owner test * chore: Can't add item to published collection test * chore: Add test for when item is being removed from a collection * chore: Test item rarity can't be changed when collection is published * fix: Ignore tests outside of src * chore: Add success test * refactor: Refactor tests * fix: Test config * refactor: Move function * chore: Add more tests and validate that provided collection id exists * chore: Delete stub test * chore: Enable coverage report * fix: use data from database for items * feat: Curation table + endpoints (#279) * chore: Add migration and some code for Curations table * chore: Add collection utils and post curation handler * chore: Add get requests * fix: Curation static functions * chore: Add Collection util tests * chore: Add curation router to server * chore: Add tests for curation router * chore: Add coverage report * chore: Query collections by authorized user * fix: Github actions * fix: Github actions * fix: Github actions * fix: Github actions * refactor: Rename hasAccess function * chore: Add access tests * fix: Get Curations * refactor: Format * fix: Query * fix: Add created and updated at * fix: Fix stored date in db * refactor: Store status in curation + fix tests * feat: Patch curation endpoint * fix: Rename data property for update curation * fix: Update curation * fix: Don't check with created_at but with pending status * Merge master with node 14 compatibility (#293) * chore: Restart server * chore: Restart server * feat: Return stringified cached default asset packs (#285) * feat: Return strigified asset packs * chore: Make some minor fixes for the router and add tests * chore: Set default address * chore: Refactor getDefaultAssetPacks to return both caches * chore: Refactors * chore: Fix PR comments * chore: Remove redundant check * chore: Restart server * feat: add lock to collections and API tests (#287) * feat: add lock to collections and API tests * chore: add necessary env vars * feat: better test mocks * chore: Init server with inspector (#288) * feat: Add the bastion security group (#291) * fix: Add async and default error handler (#290) * fix: Add async & default error handler * fix: Remove async handler from project manifest * chore: Add tests for the error handler * fix: Tests * fix: SyncHttpError test * fix: Remove the bastion security group * Revert "fix: Remove the bastion security group" This reverts commit efa7522. * fix: Prometheus stack * fix: CI compiling * fix: Revert back to an older version of dcl-tools * chore: Upgrade dependencies and node version (#292) * chore: Upgrade decentraland-server and node version * chore: Use the node 14 version for circle ci * Upgrading dockerfile * chore: Update docker image * chore: Run node 14 on GH CI * chore: Revert migration script * chore: Remove the no-check order flag * chore: Move curations migration order Co-authored-by: Lautaro Petaccio <lausuper@gmail.com> Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com> * chore: Merge master (#301) * chore: Merge master * chore: Move migration * feat: add content hash (#303) * feat: added content hash to item * chore: added source maps * chore: make endpoints restuful * fix: query * chore: merge master into improve approve flow (#304) Co-authored-by: Juan Cazala <juancazala@gmail.com> Co-authored-by: Lautaro Petaccio <lausuper@gmail.com> Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com> Co-authored-by: Juan Cazala <juan@decentraland.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
content_hash
property toItem
. It's not stored in the DB, it comes from the remote item (subgraph).