Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add content hash #303

Merged
merged 5 commits into from
Oct 8, 2021

Conversation

cazala
Copy link
Member

@cazala cazala commented Oct 7, 2021

Adds content_hash property to Item. It's not stored in the DB, it comes from the remote item (subgraph).

@cazala cazala requested a review from fzavalia October 7, 2021 23:11
@coveralls
Copy link

coveralls commented Oct 7, 2021

Pull Request Test Coverage Report for Build 1320679633

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 48.4%

Totals Coverage Status
Change from base Build 1317673745: -0.03%
Covered Lines: 1154
Relevant Lines: 2157

💛 - Coveralls

Copy link
Contributor

@fzavalia fzavalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
The routes seem better like this

@cazala cazala merged commit 5b21fa5 into feat/improve-wearables-approval-flow Oct 8, 2021
@cazala cazala deleted the feat/add-content-hash branch October 8, 2021 14:47
cazala added a commit that referenced this pull request Oct 8, 2021
* feat: Accept changes for items in a published collection (#270)

* feat: Items of published collections can be upserted

* fix: isCollectionOwnerDifferent

* fix: isItemCollectionBeingChanged

* fix: isItemCollectionBeingChanged

* refactor: Use less '?.' and ternary operators

* feat: Add jest + simple test

* Update jest.config.js

* chore: Add test:watch npm script

* chore: Add more tests

* chore: More tests

* chore: Reset mocks

* chore: Collection with different owner test

* chore: Can't add item to published collection test

* chore: Add test for when item is being removed from a collection

* chore: Test item rarity can't be changed when collection is published

* fix: Ignore tests outside of src

* chore: Add success test

* refactor: Refactor tests

* fix: Test config

* refactor: Move function

* chore: Add more tests and validate that provided collection id exists

* chore: Delete stub test

* chore: Enable coverage report

* fix: use data from database for items

* feat: Curation table + endpoints (#279)

* chore: Add migration and some code for Curations table

* chore: Add collection utils and  post curation handler

* chore: Add get requests

* fix: Curation static functions

* chore: Add Collection util tests

* chore: Add curation router to server

* chore: Add tests for curation router

* chore: Add coverage report

* chore: Query collections by authorized user

* fix: Github actions

* fix: Github actions

* fix: Github actions

* fix: Github actions

* refactor: Rename hasAccess function

* chore: Add access tests

* fix: Get Curations

* refactor: Format

* fix: Query

* fix: Add created and updated at

* fix: Fix stored date in db

* refactor: Store status in curation + fix tests

* feat: Patch curation endpoint

* fix: Rename data property for update curation

* fix: Update curation

* fix: Don't check with created_at but with pending status

* Merge master with node 14 compatibility (#293)

* chore: Restart server

* chore: Restart server

* feat: Return stringified cached default asset packs (#285)

* feat: Return strigified asset packs

* chore: Make some minor fixes for the router and add tests

* chore: Set default address

* chore: Refactor getDefaultAssetPacks to return both caches

* chore: Refactors

* chore: Fix PR comments

* chore: Remove redundant check

* chore: Restart server

* feat: add lock to collections and API tests (#287)

* feat: add lock to collections and API tests

* chore: add necessary env vars

* feat: better test mocks

* chore: Init server with inspector (#288)

* feat: Add the bastion security group (#291)

* fix: Add async and default error handler (#290)

* fix: Add async & default error handler

* fix: Remove async handler from project manifest

* chore: Add tests for the error handler

* fix: Tests

* fix: SyncHttpError test

* fix: Remove the bastion security group

* Revert "fix: Remove the bastion security group"

This reverts commit efa7522.

* fix: Prometheus stack

* fix: CI compiling

* fix: Revert back to an older version of dcl-tools

* chore: Upgrade dependencies and node version (#292)

* chore: Upgrade decentraland-server and node version

* chore: Use the node 14 version for circle ci

* Upgrading dockerfile

* chore: Update docker image

* chore: Run node 14 on GH CI

* chore: Revert migration script

* chore: Remove the no-check order flag

* chore: Move curations migration order

Co-authored-by: Lautaro Petaccio <lausuper@gmail.com>
Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>

* chore: Merge master (#301)

* chore: Merge master

* chore: Move migration

* feat: add content hash (#303)

* feat: added content hash to item

* chore: added source maps

* chore: make endpoints restuful

* fix: query

* chore: merge master into improve approve flow (#304)

Co-authored-by: Juan Cazala <juancazala@gmail.com>
Co-authored-by: Lautaro Petaccio <lausuper@gmail.com>
Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
Co-authored-by: Juan Cazala <juan@decentraland.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants