feat: return third party collections #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1409746498
💛 - Coveralls |
nicosantangelo
force-pushed
the
fix/get-collecitons
branch
2 times, most recently
from
92718ae
to
6f927d0
Compare
nicosantangelo
changed the title
LautaroPetaccio
requested changes
Nov 1, 2021
| }) | ||
| }) | ||
|
|
||
| describe('when the graph third party records', () => { |
There was a problem hiding this comment.
Suggested change
| describe('when the graph third party records', () => { | |
| describe('when the graph has third party records', () => { |
| ]) | ||
| }) | ||
|
|
||
| it('should the db collection with the added eth_address', async () => { |
There was a problem hiding this comment.
Suggested change
| it('should the db collection with the added eth_address', async () => { | |
| it('should return the db collections of the third party collections with managed by the given address', async () => { |
| }) | ||
|
|
||
| describe('when getting the database TPW collections', () => { | ||
| const service = new CollectionService() |
There was a problem hiding this comment.
It might be better to have this initialized in a before each in case we decide to make it stateful.
nicosantangelo
force-pushed
the
fix/get-collecitons
branch
from
ce46d35
to
ba17ebb
Compare
nicosantangelo
force-pushed
the
fix/get-collecitons
branch
from
2b44c16
to
162f53c
Compare
LautaroPetaccio
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the utils method to avoid confusion. We can add a
isTPCollection(collection: CollectionAttributes)that checks for third_party_id later