Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add checks to upserts of TPW collections #339

Merged
merged 18 commits into from
Nov 1, 2021

Conversation

LautaroPetaccio
Copy link
Contributor

This PR does the following:

  • Adds a missing check for upserting a collection into a third party (that is, a collection that didn't have urn_suffix or third_party_id now has one).
  • Updates the tpwCollectionURNRegex to capture the urn_suffix that was not being captured before.
  • Removes duplicated validation schema that was being already checked using the middleware.
  • Adds a check to prevent third party collections with published items from changing the collection's URN.

The PR depends on #327, once it gets merged, the branch will be re-pointed to master.
Closes #317

@coveralls
Copy link

coveralls commented Oct 29, 2021

Pull Request Test Coverage Report for Build 1409400932

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 62.638%

Totals Coverage Status
Change from base Build 1409388749: 0.3%
Covered Lines: 1622
Relevant Lines: 2438

💛 - Coveralls

Copy link
Contributor

@nicosantangelo nicosantangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feat/deletion-of-tpc to master November 1, 2021 19:33
@LautaroPetaccio LautaroPetaccio merged commit df81240 into master Nov 1, 2021
@LautaroPetaccio LautaroPetaccio deleted the feat/upsert-third-party-collection-checks branch November 1, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for updating Third Party Collections
3 participants