feat: Add pattern check to the name and the description of the items #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1536550106
💛 - Coveralls |
Comment on lines
+11
to
+15
| name: { type: 'string', maxLength: 32, pattern: '^[^:]*$' }, | ||
| description: { | ||
| type: ['string', 'null'], | ||
| maxLength: 64, | ||
| pattern: '^[^:]*$', |
There was a problem hiding this comment.
shouldn't these have a + instead of an * ? or at least a minLength key?
There was a problem hiding this comment.
The only check that the builder has is this one, there's sadly no check about the length. We could add one, but we'll be potentially introducing a breaking change.
nicosantangelo
approved these changes
Dec 7, 2021
LautaroPetaccio
deleted the
feat/add-text-patter-to-item-name-and-description
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple pattern to exclude any names and descriptions of items that disallows using
:in them.