-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tp is published and is approved #378
Merged
Merged
Changes from 24 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
d0f7e5d
feat: split curation in items/curations
nicosantangelo 9e25a74
chore: param names
nicosantangelo bdbce66
feat: create virtual TPW collection curations
nicosantangelo 8fd4a2d
feat: add is published to TPW collections (and a bunch of bugs)
nicosantangelo f63a0bd
fix: correctly check tpw collection publishes
nicosantangelo 68e24f2
feat: groundwork for item isPublished/isApproved
nicosantangelo 2b5fd3d
feat: consolidate items
nicosantangelo 925db31
Merge branch 'feat/tpw-is-published' of github.com:decentraland/build…
nicosantangelo f2df8e3
feat: getItem
nicosantangelo 74ffe17
feat: finish item and collection endpoints (missing tests)
nicosantangelo a4f6b73
fix: collection router specs
nicosantangelo 578b68a
WIP
nicosantangelo 23afbfc
WIP
nicosantangelo ea7c62d
feat: tests
nicosantangelo d38c5a6
chore: lint
nicosantangelo b5195e9
Merge branch 'master' into feat/tpw-is-published
nicosantangelo 059935c
feat: tests
nicosantangelo cd46135
chore: lint
nicosantangelo c5c0700
feat: extract getCollectionItems
nicosantangelo 67e70c6
feat: extract getCollection
nicosantangelo f862202
feat: remove eth_address and managers from TP elements
nicosantangelo 97307de
chore: fix rebase mixup
nicosantangelo aafc5a7
feat: simpler tp consolidation
nicosantangelo f8a5a72
fix: script
nicosantangelo 568dff5
fix: collection_id instead of id
nicosantangelo fd55b10
feat: remove repeated migrations. Renames
nicosantangelo 9623160
feat: remove complexity for service call
nicosantangelo bdaf724
chore: test name
nicosantangelo 20d81dd
feat: bridge feedback
nicosantangelo d7e9d1d
Merge branch 'master' into feat/tpw-is-published
nicosantangelo 3417c6a
fix: rebase
nicosantangelo a537d57
fix: feedback
nicosantangelo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { MigrationBuilder } from 'node-pg-migrate' | ||
import { CollectionCuration } from '../src/Curation/CollectionCuration' | ||
|
||
export const up = (pgm: MigrationBuilder) => { | ||
pgm.renameTable('curations', CollectionCuration.tableName) | ||
} | ||
|
||
export const down = (pgm: MigrationBuilder) => { | ||
pgm.renameTable(CollectionCuration.tableName, 'curations') | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import { MigrationBuilder } from 'node-pg-migrate' | ||
import { Collection } from '../src/Collection' | ||
import { ItemCuration } from '../src/Curation/ItemCuration' | ||
|
||
const tableName = ItemCuration.tableName | ||
|
||
export const up = (pgm: MigrationBuilder) => { | ||
pgm.createTable( | ||
tableName, | ||
{ | ||
id: { type: 'UUID', primaryKey: true, unique: true, notNull: true }, | ||
item_id: { type: 'UUID', notNull: true }, | ||
status: { type: 'CURATION_STATUS', notNull: true }, | ||
created_at: { type: 'TIMESTAMP', notNull: true }, | ||
updated_at: { type: 'TIMESTAMP', notNull: true }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I'm not wrong, this has already been created in #378. |
||
}, | ||
{ | ||
ifNotExists: true, | ||
constraints: { | ||
foreignKeys: { | ||
references: Collection.tableName, | ||
columns: 'item_id', | ||
onDelete: 'CASCADE', | ||
}, | ||
}, | ||
} | ||
) | ||
|
||
pgm.createIndex(tableName, 'item_id') | ||
} | ||
|
||
export const down = (pgm: MigrationBuilder) => { | ||
pgm.dropTable(tableName, {}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be already complete in #378
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't #378 this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! #379 right? I think this and the migration slipped thru the rebase