feat: add SlotUsageCheque #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1843145586
💛 - Coveralls |
LautaroPetaccio
requested changes
Feb 11, 2022
| id: { type: 'UUID', primaryKey: true, unique: true, notNull: true }, | ||
| signature: { type: 'TEXT', notNull: true }, | ||
| quantity: { type: 'TEXT', notNull: true }, | ||
| salt: { type: 'TEXT', notNull: true }, |
There was a problem hiding this comment.
Do we need the salt to be a column? Ins't it going to be part of the signed message?
There was a problem hiding this comment.
It is, but we decided on adding it here too when creating #390 with @nachomazzara . I can't really recall if it's necessary now
| tableName, | ||
| { | ||
| id: { type: 'UUID', primaryKey: true, unique: true, notNull: true }, | ||
| signature: { type: 'TEXT', notNull: true }, |
There was a problem hiding this comment.
Is it signature or signed message?
There was a problem hiding this comment.
signed message sounds better I think
LautaroPetaccio
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #390