fix: Find third party ids query #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1970387670
💛 - Coveralls |
src/Item/Item.model.ts
Outdated
| WHERE collections.third_party_id = ANY(${thirdPartyIds})`) | ||
| SELECT ${itemsTable}.* | ||
| FROM ${itemsTable} | ||
| JOIN ${collectionsTable} ON collections.id = ${itemsTable}.collection_id |
There was a problem hiding this comment.
missing a ${collectionsTable} here right? (collections.id)
Question: it's a good idea to do this in general to avoid typos, but at the same time it makes the query really difficult to read. Can we strike a balance perhaps? shorter names but using the string in the query?
(we might need tests for queries heh)
There was a problem hiding this comment.
Ups, added it!
What makes me doubt is that we have the table name used as a variable for what I think is to avoid typos (or be reactive when the table changes), but we're only using it for the table once.
migrations/migrate.ts
Outdated
| @@ -17,6 +17,7 @@ export function migrate( | |||
| } | |||
|
|
|||
| const spawnArgs = [ | |||
| '--no-check-order', | |||
nicosantangelo
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where we were using
iteminstead ofitemswhen naming a table.The aliases were removed, as the names of the collections are sufficient enough for this query and the table names were replaced by their table variable.