feat: Approval data return a dictionary instead of array of hashes #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1988329668
💛 - Coveralls |
LautaroPetaccio
requested changes
Mar 15, 2022
| @@ -20,7 +20,7 @@ export class Item extends Model<ItemAttributes> { | |||
| FROM ${raw(this.tableName)} items | |||
| JOIN ${raw( | |||
| ItemCuration.tableName | |||
| )} item_curations ON items.id = item_curations.item_id AND | |||
| )} item_curations ON items.id = item_curations.item_id | |||
There was a problem hiding this comment.
I was thinking that the tree to be built requires not only this data, but the data of all the items that are published for a third party. We need all the data to re-build the tree, and the tree is built with all the items of a third party.
There was a problem hiding this comment.
True, I think then that the query should not check for curation status but rather for curation "existence", which is already being done by the INNER JOIN right?
There was a problem hiding this comment.
Alright, as Nico suggested, we can take care of that in another PR. Issue created: #439
nicosantangelo
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
The changes are 💯
The conversation here can be done in another issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.