feat: emotes #453
Merged
feat: emotes #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cazala
commented
Mar 18, 2022
| @@ -31,7 +32,7 @@ export const itemSchema = Object.freeze({ | |||
| created_at: { type: 'string' }, | |||
| updated_at: { type: 'string' }, | |||
| type: { enum: Object.values(ItemType) }, | |||
| data: { type: 'object', oneOf: [wearableSchema] }, | |||
| data: { type: 'object', anyOf: [wearableSchema, emoteSchema] }, | |||
There was a problem hiding this comment.
I changed oneOf to anyOf otherwise lots of tests fail, because some of the data used on test cases are both valid wearable AND emote schemas, and oneOf throws if there's more than 1 schema passing. anyOf allows both schemas to pass.
Pull Request Test Coverage Report for Build 2006533369
💛 - Coveralls |
LautaroPetaccio
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Emote schemas