fix: Check the amount of TP items to be published #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2102601502
💛 - Coveralls |
LautaroPetaccio
requested changes
Apr 6, 2022
src/Collection/Collection.router.ts
Outdated
Comment on lines
317
to
326
| const availableSlots = await this.tpService.getThirdPartyAvailableSlots( | ||
| dbCollection.third_party_id | ||
| ) | ||
| if (itemIds.length > availableSlots) { | ||
| throw new HTTPError( | ||
| 'The amount of items to publish exceeds the available slots', | ||
| null, | ||
| STATUS_CODES.badRequest | ||
| ) | ||
| } |
There was a problem hiding this comment.
Would you mind putting this into the publishTPCollection method?
We'll need to create a custom Error and catch it as well.
There was a problem hiding this comment.
Also, what if we use a 409 for this error?
There was a problem hiding this comment.
Absolutely! updated :)
LautaroPetaccio
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #480