Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pagination and filters to the /collections endpoint #514

Merged
merged 5 commits into from
May 16, 2022

Conversation

juanmahidalgo
Copy link
Contributor

Description

  • Adds support for pagination params limit and page.
  • Adds filters for: assignee, status , q, is_published
  • Adds sort option to sort by relevance, name_asc, name_desc and newest

Closes #513

@coveralls
Copy link

coveralls commented May 6, 2022

Pull Request Test Coverage Report for Build 2312215779

  • 46 of 68 (67.65%) changed or added relevant lines in 5 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.8%) to 68.922%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ethereum/api/Bridge.ts 12 13 92.31%
src/Collection/Collection.model.ts 3 24 12.5%
Files with Coverage Reduction New Missed Lines %
src/Collection/Collection.service.ts 1 93.66%
src/Item/hashes.ts 1 94.12%
src/ethereum/api/Bridge.ts 10 80.0%
Totals Coverage Status
Change from base Build 2257856043: -0.8%
Covered Lines: 2567
Relevant Lines: 3555

💛 - Coveralls

@juanmahidalgo juanmahidalgo marked this pull request as draft May 6, 2022 13:26
@juanmahidalgo juanmahidalgo marked this pull request as ready for review May 9, 2022 08:14
@juanmahidalgo juanmahidalgo merged commit 32d02d9 into master May 16, 2022
@juanmahidalgo juanmahidalgo deleted the feat/paginate-collections-endpoint branch May 16, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paginate /collections endpoints
3 participants