fix: add default order for items by created_at #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2435095237
💛 - Coveralls |
2 tasks
LautaroPetaccio
requested changes
Jun 3, 2022
src/Item/Item.model.ts
Outdated
Comment on lines
203
to
208
| WHERE items.collection_id = ANY(${collectionIds}) | ||
| AND ${ | ||
| status && status === CurationStatus.PENDING | ||
| ? SQL`items.blockchain_item_id IS NULL` | ||
| : SQL`1 = 1` | ||
| } |
There was a problem hiding this comment.
The blockchain_item_id is independent from the curation status as it's set once the collection is published.
Standard items don't have curation statuses, their collection can have (once it changes and is up to re-review) a curation so I wouldn't mix that concept in the query unless we wanted to get the items of a collection with a pending status.
There was a problem hiding this comment.
Isn't this that case? The status is for the items that are getting asked.
If we're asking for pending items, shouldn't we return the ones with blockchain_item_id NOT null? I might be missing something here..
juanmahidalgo
changed the title
LautaroPetaccio
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #538