Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: looped emotes #596

Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix: looped emotes #596

merged 1 commit into from
Sep 15, 2022

Conversation

cazala
Copy link
Member

@cazala cazala commented Sep 15, 2022

This PR removes the loop: false hardcoded on the server. When the looped emotes are enabled in the frontend, this thing hardcoded here causes the hashes to be computed differently in the server than in the frontend, and eventually that leads to the catalyst rejecting the deployment of looped emotes.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3062420397

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 68.015%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Item/hashes.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/Item/hashes.ts 1 76.47%
Totals Coverage Status
Change from base Build 3016871034: -0.01%
Covered Lines: 2658
Relevant Lines: 3718

💛 - Coveralls

@cazala cazala merged commit d47fa51 into master Sep 15, 2022
@cazala cazala deleted the fix/looped-emotes branch September 15, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants