Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update logic to move allowed items between collections #619

Merged
merged 3 commits into from
Jan 4, 2023
Merged

feat: Update logic to move allowed items between collections #619

merged 3 commits into from
Jan 4, 2023

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Dec 10, 2022

This PR allows moving items between unpublished collections.

Closes #2347

@cyaiox cyaiox mentioned this pull request Dec 10, 2022
Merged
@coveralls
Copy link

coveralls commented Dec 10, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3684700237

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 68.188%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Item/Item.service.ts 9 11 81.82%
Totals Coverage Status
Change from base Build 3523341755: 0.01%
Covered Lines: 2684
Relevant Lines: 3749
💛 - Coveralls

juanmahidalgo
juanmahidalgo approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@juanmahidalgo juanmahidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👏

@juanmahidalgo juanmahidalgo merged commit 2d8c30f into master Jan 4, 2023
@juanmahidalgo juanmahidalgo deleted the feat/move-items-to-another-collection branch January 4, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanmahidalgo juanmahidalgo juanmahidalgo approved these changes

@LautaroPetaccio LautaroPetaccio Awaiting requested review from LautaroPetaccio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cyaiox @coveralls @juanmahidalgo