Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow land coords with x or y as 0 #621

Merged
merged 2 commits into from
Jan 4, 2023
Merged

fix: Allow land coords with x or y as 0 #621

merged 2 commits into from
Jan 4, 2023

Conversation

LautaroPetaccio
Copy link
Contributor

Land coordinates can have x or y as 0. This PR fixes that.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3840221388

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.141%
Totals Coverage Status
Change from base Build 3838427224: 0.0%
Covered Lines: 2687
Relevant Lines: 3755
💛 - Coveralls

@LautaroPetaccio LautaroPetaccio merged commit 2040a4d into master Jan 4, 2023
@LautaroPetaccio LautaroPetaccio deleted the fix/allow-land-coords-with-0 branch January 4, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzavalia fzavalia fzavalia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LautaroPetaccio @coveralls @fzavalia