Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow TP collections to post to forum after published #660

Merged
merged 1 commit into from
Jun 12, 2023
Merged

fix: Allow TP collections to post to forum after published #660

merged 1 commit into from
Jun 12, 2023

Conversation

kevinszuchet
Copy link
Contributor

No description provided.

@kevinszuchet kevinszuchet marked this pull request as draft June 12, 2023 15:36
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5245606476

  • 10 of 25 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 68.641%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Forum/Forum.router.ts 10 25 40.0%
Totals Coverage Status
Change from base Build 5218954906: -0.2%
Covered Lines: 2707
Relevant Lines: 3805
💛 - Coveralls

juanmahidalgo
juanmahidalgo approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@juanmahidalgo juanmahidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@kevinszuchet kevinszuchet marked this pull request as ready for review June 12, 2023 15:48
@kevinszuchet kevinszuchet merged commit 30c2816 into master Jun 12, 2023
4 checks passed
@kevinszuchet kevinszuchet deleted the fix/allow-posting-tp-collections-to-forum-after-publishing branch June 12, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanmahidalgo juanmahidalgo juanmahidalgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinszuchet @coveralls @juanmahidalgo