fix: Update SW video field #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5942496375
💛 - Coveralls |
src/Curation/Curation.router.ts
Outdated
| */ | ||
| private updateCollectionItemsContent = async (collectionId: string) => { | ||
| const itemService = new ItemService() | ||
| itemService.updateDCLItemsContent(collectionId) |
There was a problem hiding this comment.
Should we add the await here?
There was a problem hiding this comment.
you're right! added the await
kevinszuchet
approved these changes
Aug 22, 2023
src/Curation/Curation.router.spec.ts
Outdated
Comment on lines
653
to
661
| updateSpy = jest | ||
| .spyOn(service, 'updateById') | ||
| .mockResolvedValueOnce(expectedCuration) | ||
| const updateItemSpy = jest | ||
| .spyOn(Item, 'upsert') | ||
| .mockResolvedValue({ | ||
| ...mockItem, | ||
| video: newVideoHash, | ||
| }) |
There was a problem hiding this comment.
Would you mind setting these two in the beforeEach?
The same goes for the other test.
src/Item/Item.service.spec.ts
Outdated
| }, | ||
| video: 'videoHash', | ||
| } | ||
| ;(Item.findOne as jest.Mock).mockRestore() |
There was a problem hiding this comment.
Did you need to use restores because there was an issue with the mocks?
There was a problem hiding this comment.
not required the restores, removing it
src/Item/Item.service.spec.ts
Outdated
Comment on lines
133
to
138
| ;(collectionAPI.fetchCollection as jest.Mock).mockImplementation(() => | ||
| Promise.resolve({ | ||
| ...collectionFragmentMock, | ||
| creator: oldCreatorAddress, | ||
| }) | ||
| ) |
There was a problem hiding this comment.
The mocks that return values can be simplified using the resolve or return mocks. Would you mind changing them?
Suggested change
| ;(collectionAPI.fetchCollection as jest.Mock).mockImplementation(() => | |
| Promise.resolve({ | |
| ...collectionFragmentMock, | |
| creator: oldCreatorAddress, | |
| }) | |
| ) | |
| ;(collectionAPI.fetchCollection as jest.Mock).mockResolvedValueOnce({ | |
| ...collectionFragmentMock, | |
| creator: oldCreatorAddress, | |
| }) |
src/Item/Item.service.spec.ts
Outdated
| ;(Item.findOne as jest.Mock).mockRestore() | ||
| ;(Item.findOne as jest.Mock).mockResolvedValueOnce(dbItem) | ||
| ;(Item.hasPublishedItems as jest.Mock).mockResolvedValue(true) | ||
| ;(Item.upsert as jest.Mock).mockImplementation((value) => value) |
There was a problem hiding this comment.
Would you mind using the once version of the mocks? This will prevent the mocks from leaking into other tests.
cyaiox
force-pushed
the
fix/update-sw-video-field
branch
from
60e5b04
to
9b0baa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the video field for smart wearables when approving a curation.